Issue 214 and 205 #290
Merged
Issue 214 and 205 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robmwalsh could you coordinate 🙏 ? Solves similar problem to #263 |
robmwalsh
suggested changes
Nov 26, 2020
There was a problem hiding this comment.
Awesome work here @antoniograndinetti! A few things to fix up, mainly relating to types. You've stumbled into some of the slightly more complicated type machinery here - I've tried to explain the relevant bits but feel free to ask if anything's unclear.
postgres/src/main/scala/zio/sql/postgresql/PostgresModule.scala
Outdated
Show resolved
Hide resolved
postgres/src/main/scala/zio/sql/postgresql/PostgresModule.scala
Outdated
Show resolved
Hide resolved
postgres/src/main/scala/zio/sql/postgresql/PostgresModule.scala
Outdated
Show resolved
Hide resolved
robmwalsh
suggested changes
Nov 27, 2020
There was a problem hiding this comment.
Nice work here @antoniograndinetti - just a few more things to go to make the parenless functions parenless in our DSL as well, and a bit of extra type safety
postgres/src/main/scala/zio/sql/postgresql/PostgresModule.scala
Outdated
Show resolved
Hide resolved
postgres/src/test/scala/zio/sql/postgresql/FunctionDefSpec.scala
Outdated
Show resolved
Hide resolved
jczuchnowski
approved these changes
Nov 28, 2020
|
Awesome work here @antoniograndinetti! Thanks for your contribution |
amrkamel
pushed a commit
to amrkamel/zio-sql
that referenced
this pull request
May 26, 2022
Issue 214 and 205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
Fixes #205